Fix imports of the "electron" module that are missing an Electron guard #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
absidue
changed the title
absidue
force-pushed
the
fix-is-electron
branch
from
233bca7 to
9b9d42c
Compare
ChunkyProgrammer
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Should we add a yarn run pack:web to the linter ci too so we can make sure we dont merge things that break the web builds? (Even though we dont officially support the web builds)
FreeTube/.github/workflows/linter.yml
Line 29 in e659462
PikachuEXE
approved these changes
Apr 13, 2024
We could if you want. |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 14, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix imports of the "electron" module that are missing an Electron guard
Pull Request Type
Related issue
Noticed them while working on #4931
Description
Currently some of our imports of the
electronmodule are correctly guarded byIS_ELECTRONchecks, others unfortunately are not which means the web webpack config (and the downstream Android one) need to tell webpack to ignore theelectronimports. This pull request adds the guards in the places that there were missing.I recommend turning on GitHub's
Hide Whitespacesetting while reviewing this pull request, especially for thesrc/renderer/store/modules/settings.jsfile.Testing
Run
yarn run pack:web, if it doesn't complain about not being able to bundle Electron, I didn't forget to add a guard.Desktop